minizip seems to be changing to a hex number for MZ_VERSION_BUILD#1954
Closed
opoplawski wants to merge 1 commit into
Closed
minizip seems to be changing to a hex number for MZ_VERSION_BUILD#1954opoplawski wants to merge 1 commit into
opoplawski wants to merge 1 commit into
Conversation
The committers listed above are authorized under a signed CLA. |
doug-walker
reviewed
Mar 18, 2024
Collaborator
There was a problem hiding this comment.
Thanks for proposing a fix, but does it actually work with all releases of minizip-ng? Maybe we need to switch to parsing MZ_VERSION rather than trying to deal with their switching MZ_VERSION_BUILD from decimal to octal to hex?
Linking issue #1818 for reference.
Contributor
|
I think we should parse |
Contributor
|
The cmake module that detects minizip does parse the MZ_VERSION from |
Collaborator
|
Closing as this is no longer relevant after PR #2192. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This hasn't been released yet but:
zlib-ng/minizip-ng@a7d612a
zlib-ng/minizip-ng#758